[
https://issues.apache.org/jira/browse/LUCENE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937690#comment-13937690
]
Shai Erera commented on LUCENE-5533:
------------------------------------
bq. But maybe we should break out a LongTaxonomyFacets instead?
+1, and especially as it's only relevant to association-based faceting.
Rob, is this something you really hit or just a random code review? I agree
when you sum integers there's a risk of overflowing, but I'm afraid if we
introduce LongTaxoFacets users might want to use it "just in case". The risk is
that a single ord will overflow, right?
I wonder if we should use a packed long buffer instead of a plain long[] ...
that's optimization though. First let's agree that this is something that needs
fixing.
> TaxonomyFacetSumIntAssociations overflows, unpredicted results
> --------------------------------------------------------------
>
> Key: LUCENE-5533
> URL: https://issues.apache.org/jira/browse/LUCENE-5533
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Affects Versions: 4.7
> Reporter: Rob Audenaerde
>
> {{TaxonomyFacetSumIntAssociations}} extends {{IntTaxonomyFacets}} which uses
> a {{int[]}} to store values. If you sum a lot of integers in the
> IntAssociatoins, the {{int}} will overflow.
> The easiest fix seems to change the {{value[]}} to {{long}}?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
