[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938808#comment-13938808
]
Shai Erera commented on LUCENE-5513:
------------------------------------
Thanks Mike, will wrap up and commit.
One thing I wanted to note, and specifically emphasized in javadocs, is that
IW.updateBinaryDocValue *replaces* the existing byte[] value of all affected
documents. We could also easily implement an _append_ type of update, where the
given bytes are appended to all affected documents. It's only a matter of
defining that on the update itself and in ReaderAndUpdates, instead of
overriding a document's value, we read its current value from the reader and
append the new bytes.
Unlike NDV updates, append for Binary (and SortedSet) has more value, since it
lets you add values to documents whose existing values may not be currently
identical, where the current implementation ignores _all_ existing values and
makes all affected documents identical. Perhaps it's acceptable, depending on
the nature of the update (e.g. update by PK), but I think we should explore
adding update capabilities to Binary and SortedSet DV. And also the IW.update
API to allow updating by more than just Term, e.g. this thread:
http://markmail.org/message/2wmpvksuwc5t57pg.
These are all for separate issues though.
> Binary DocValues Updates
> ------------------------
>
> Key: LUCENE-5513
> URL: https://issues.apache.org/jira/browse/LUCENE-5513
> Project: Lucene - Core
> Issue Type: Wish
> Components: core/index
> Reporter: Mikhail Khludnev
> Priority: Minor
> Attachments: LUCENE-5513.patch, LUCENE-5513.patch, LUCENE-5513.patch,
> LUCENE-5513.patch
>
>
> LUCENE-5189 was a great move toward. I wish to continue. The reason for
> having this feature is to have "join-index" - to write children docnums into
> parent's binaryDV. I can try to proceed the implementation, but I'm not so
> experienced in such deep Lucene internals. [~shaie], any hint to begin with
> is much appreciated.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
