Uwe Schindler created LUCENE-5537:
-------------------------------------
Summary: Fix version check in TestCheckIndexes
Key: LUCENE-5537
URL: https://issues.apache.org/jira/browse/LUCENE-5537
Project: Lucene - Core
Issue Type: Bug
Components: core/other
Affects Versions: 4.7
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Priority: Blocker
Fix For: 4.8, 5.0, 4.7.1
The crazy version check in TestCheckIndexes is broken. Whenever it fails, it
requires a horrible amount of understanding:
- error messages are useless
- you don't know what it really checks and why (no documentation)
In addition, we have no clear workflow how to handle version updates:
- In 4.6 series we never set the dev.version in common-build to 4.6.1, it
always stayed 4.6. The test worked therefore, because the LUCENE_MAIN_VERSION
(which is always "x.y") was identical
- In 4.7 [~steve_rowe] changed the version to the real release version in the
branch. The test failed because of this change (LUCENE_MAIN_VERSION was not
identical as the dotted bugfix version)
We should in any case fix the test:
- move it out of TestCheckIndex, it should be in oal.util.TestConstants
- Be more verbose on loggin
- Remove special cases (leftovers from 4.0-BETA) where we did crazy stuff to
make this test pass in alphas and betas.
We should also document and write down when we change the version numbers. I
would prefer to use the variant of Lucene 4.6: never change the version number
in common-build and "override" it while building artifacts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
