[
https://issues.apache.org/jira/browse/LUCENE-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939119#comment-13939119
]
Uwe Schindler commented on LUCENE-5537:
---------------------------------------
Hi Robert,
I agree with that on trunk. But in the stable branch we should ensure with the
regex, that the MAIN_VERSIOn is "x.y", so we prevent anybody doing releases to
put "4.7.1" into the LUCENE_MAIN_VERSION.
In trunk we can have the stuff with "5.0.*0*.x" for alpha beta (the code checks
if 3rd part is "0" to detect BETA. But in stable releases we should prevent
that.
So I can preserve your check in trunk, in 4.x I enforce "x.y". Is this fine for
you?
You agree that cleaning that up and especially adding a more detailed comment
about how to handle BETA versions would be ok? If not, please take this issue
and do the cleanup yourself. All this shit with startWith and so on is
un-understandable. I just cleaned it up and it took me also half a day to test
this with all branches and version comibantions, not counted the time to
understand that stuff (without a good comment).
Steve did not break the build, the build was broken by me in my last commit. It
was just not detected in 4.6.1, because we did not change common-build.
> Fix version check in TestCheckIndexes
> -------------------------------------
>
> Key: LUCENE-5537
> URL: https://issues.apache.org/jira/browse/LUCENE-5537
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other
> Affects Versions: 4.7
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Blocker
> Fix For: 4.8, 5.0, 4.7.1
>
> Attachments: LUCENE-5537.patch
>
>
> The crazy version check in TestCheckIndexes is broken. Whenever it fails, it
> requires a horrible amount of understanding:
> - error messages are useless
> - you don't know what it really checks and why (no documentation)
> In addition, we have no clear workflow how to handle version updates:
> - In 4.6 series we never set the dev.version in common-build to 4.6.1, it
> always stayed 4.6. The test worked therefore, because the LUCENE_MAIN_VERSION
> (which is always "x.y") was identical
> - In 4.7 [~steve_rowe] changed the version to the real release version in the
> branch. The test failed because of this change (LUCENE_MAIN_VERSION was not
> identical as the dotted bugfix version)
> We should in any case fix the test:
> - move it out of TestCheckIndex, it should be in oal.util.TestConstants
> - Be more verbose on loggin
> - Remove special cases (leftovers from 4.0-BETA) where we did crazy stuff to
> make this test pass in alphas and betas.
> - Only add a check to LUCENE_MAIN_VERSION that it is in format "x.y" (which
> is required by Lucene index format), and only check that it is the prefix of
> the real version as reported by common_build.xml.
> We should also document and write down when we change the version numbers. I
> would prefer to use the variant of Lucene 4.6: never change the version
> number in common-build and "override" it while building artifacts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
