[ 
https://issues.apache.org/jira/browse/SOLR-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940795#comment-13940795
 ] 

ASF subversion and git services commented on SOLR-5883:
-------------------------------------------------------

Commit 1579338 from [[email protected]] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1579338 ]

SOLR-5883: Many tests do not shutdown SolrServer.

> Shutdown SolrServer on tests
> ----------------------------
>
>                 Key: SOLR-5883
>                 URL: https://issues.apache.org/jira/browse/SOLR-5883
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.7, 5.0
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.8, 5.0
>
>         Attachments: SOLR-5883.patch
>
>
> I noticed that many tests create multiple HttpSolrServer but never call the 
> shutdown. I created a Jira for BasicDistributedZk2Test and 
> BasicDistributedZkTest some time ago but didn’t check for all tests 
> (SOLR-5684). I added the missing shutdowns that I found in other tests now. 
> I’m also wondering if it makes sense to add some kind of check in the tests, 
> in a similar way that open/close of IndexSearchers is checked (probably, not 
> blocking or falling the test if open/close doesn’t much, but maybe to output 
> a warning to the logs?)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to