[ 
https://issues.apache.org/jira/browse/LUCENE-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941165#comment-13941165
 ] 

Shawn Heisey commented on LUCENE-5130:
--------------------------------------

[~thetaphi], I need to catch you on IRC sometime.

What I am doing today is looking at what actually gets listed as a warning in 
the output from 'ant clean compile' on an unmodified trunk.  Then I ask Eclipse 
to turn one specific kind of warning that gets found there into an actual 
error, and I go and change things so that the "problem" is either fixed or the 
warning is suppressed.

I'm starting with things that are easy to fix.  So far I have separate patches 
for case fallthrough and for redundant casts.  I did find a couple of things I 
need to ask about on the case fallthrough, and right now I am running tests 
after cleaning up redundant casts.

I don't think this work really fits in this issue, but I wanted to ask before I 
open a new one.

> fail the build on compilation warnings
> --------------------------------------
>
>                 Key: LUCENE-5130
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5130
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 4.8
>
>         Attachments: LUCENE-5130.patch, LUCENE-5130.patch
>
>
> Many modules compile w/o warnings ... we should lock this in and fail the 
> build if warnings are ever added, and try to fix the warnings in existing 
> modules.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to