[
https://issues.apache.org/jira/browse/LUCENE-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944216#comment-13944216
]
Shawn Heisey edited comment on LUCENE-5551 at 3/22/14 8:19 PM:
---------------------------------------------------------------
New version of the redundant casts patch. It's a lot smaller because I
suppressed quite a lot this time.
I did make some changes where the cast seemed completely unnecessary. A lot of
those were casts from a parameterized type to same parameterized type, but some
of them were for primitive types where there seemed to be no danger of
ambiguity.
There are three classes that I know of where the warnings remain. All of them
are generated code. These are two instances of QueryParserTokenManager (one in
classic, one in surround) and StandardSyntaxParserTokenManager.
As always, feel free to object to any of the changes and request that they be
suppressed instead.
was (Author: elyograg):
New version of the redundant casts patch. It's a lot smaller because I
suppressed quite a lot this time.
I did make some changes where the cast seemed completely unnecessary. A lot of
those were casts from a parameterized type to same parameterized type, but some
of them were for primitive types where there seemed to be no danger of
ambiguity.
As always, feel free to object to any of the changes and request that they be
suppressed instead.
> Fix warnings in the ant build
> -----------------------------
>
> Key: LUCENE-5551
> URL: https://issues.apache.org/jira/browse/LUCENE-5551
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Affects Versions: 4.8
> Reporter: Shawn Heisey
> Fix For: 5.0
>
> Attachments: LUCENE-5551-fix-fallthrough.patch,
> LUCENE-5551-redundant-casts.patch, LUCENE-5551-redundant-casts.patch
>
>
> The build produces a lot of warnings. LUCENE-5130 aims to fail the build on
> certain warnings, but until we actually eliminate those warnings from the
> code, failing the build is premature.
> This issue is concerned with fixing or suppressing warnings reported by the
> ant build, anything further than that may need one or more separate issues.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
