[
https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitaliy Zhovtyuk updated SOLR-5488:
-----------------------------------
Attachment: SOLR-5488.patch
The following changes were done:
1. Removed throw new IllegalArgumentException("No stat named '"+stat+"' in this
collector " + this); in
org.apache.solr.analytics.statistics.MinMaxStatsCollector#getStat because when
no stats collected and this method requested it's not excpetional case.
2. Fixed
org.apache.solr.analytics.facet.FieldFacetTest#perc20Test
org.apache.solr.analytics.facet.FieldFacetTest#perc60Test
The reason is stats name incompatibility in
org.apache.solr.analytics.expression.BaseExpression#getValue like "percentile"
and "precentile_60". Fixed by composible stat name for percentile calls from
"percentile_" + second function argument in
org.apache.solr.analytics.statistics.StatsCollectorSupplierFactory#create.
3. Fixed
org.apache.solr.analytics.util.valuesource.FunctionTest#constantStringTest
and org.apache.solr.analytics.util.valuesource.FunctionTest#multiplyTest.
The reason order incompetibility in Maps containing stats in
org.apache.solr.analytics.statistics.StatsCollectorSupplierFactory#create
Changed to TreeMap since order by stat string should be same.
4. Fixed org.apache.solr.analytics.facet.FieldFacetTest#missingFacetTest
by adding to
org.apache.solr.analytics.accumulator.FacetingAccumulator#FacetingAccumulator
always same order for facet fields.
5. Tests in org.apache.solr.analytics.facet.FieldFacetTest was working unstable
because they depended on facet fields order returned from query. Added sorting
of result and then assert Also added sorting of stdev results between assert.
6. Removed //nocommit in row in
org.apache.solr.analytics.AbstractAnalyticsStatsTest since it did not pass
precommit.
> Fix up test failures for Analytics Component
> --------------------------------------------
>
> Key: SOLR-5488
> URL: https://issues.apache.org/jira/browse/SOLR-5488
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.7, 5.0
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch,
> SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch,
> SOLR-5488.patch, eoe.errors
>
>
> The analytics component has a few test failures, perhaps
> environment-dependent. This is just to collect the test fixes in one place
> for convenience when we merge back into 4.x
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
