[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950130#comment-13950130
]
Uwe Schindler commented on SOLR-5914:
-------------------------------------
Hi,
the last Jenkins run was successful. solr-core only had the well known
SpellChecker tests leaving folders in the worker dir.
We had one failure in solrj:
{noformat}
[junit4] Suite: org.apache.solr.common.util.ContentStreamTest
[junit4] 2> Creating dataDir:
C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800
[junit4] 2> 68449 T207 oas.SolrTestCaseJ4.buildSSLConfig Randomized ssl
(true) and clientAuth (false)
[junit4] 2> 68452 T207 oas.SolrTestCaseJ4.setUp ###Starting testURLStream
[junit4] 2> 68453 T207 oasc.SolrResourceLoader.locateSolrHome JNDI not
configured for solr (NoInitialContextEx)
[junit4] 2> 68453 T207 oasc.SolrResourceLoader.locateSolrHome solr home
defaulted to 'solr/' (could not find system property or JNDI)
[junit4] 2> 68453 T207 oasc.SolrResourceLoader.<init> new
SolrResourceLoader for deduced Solr Home: 'solr/'
[junit4] 2> 68554 T207 oas.SolrTestCaseJ4.tearDown ###Ending testURLStream
[junit4] 2> 68565 T207 oas.SolrTestCaseJ4.setUp ###Starting testFileStream
[junit4] 2> 68566 T207 oasc.SolrResourceLoader.locateSolrHome JNDI not
configured for solr (NoInitialContextEx)
[junit4] 2> 68566 T207 oasc.SolrResourceLoader.locateSolrHome solr home
defaulted to 'solr/' (could not find system property or JNDI)
[junit4] 2> 68567 T207 oasc.SolrResourceLoader.<init> new
SolrResourceLoader for deduced Solr Home: 'solr/'
[junit4] 2> 68615 T207 oas.SolrTestCaseJ4.tearDown ###Ending testFileStream
[junit4] 2> 68622 T207 oas.SolrTestCaseJ4.setUp ###Starting
testStringStream
[junit4] 2> 68623 T207 oas.SolrTestCaseJ4.tearDown ###Ending
testStringStream
[junit4] 2> 68624 T207 oas.SolrTestCaseJ4.deleteCore ###deleteCore
[junit4] 2> !!!! WARNING: best effort to remove
C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800\README
FAILED !!!!!
[junit4] 2> NOTE: test params are:
codec=FastCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=FAST,
chunkSize=271),
termVectorsFormat=CompressingTermVectorsFormat(compressionMode=FAST,
chunkSize=271)), sim=DefaultSimilarity, locale=en_IE, timezone=America/Vancouver
[junit4] 2> NOTE: Windows 7 6.1 x86/Oracle Corporation 1.7.0_51
(32-bit)/cpus=2,threads=1,free=17354576,total=84934656
[junit4] 2> NOTE: All tests run in this JVM: [TestXMLEscaping,
JettyWebappTest, CloudSolrServerTest, LargeVolumeJettyTest, TestHash,
SolrExampleStreamingTest, IteratorChainTest, TestFastInputStream,
ContentStreamTest]
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=ContentStreamTest
-Dtests.seed=32A8B44CEE4187EC -Dtests.slow=true -Dtests.locale=en_IE
-Dtests.timezone=America/Vancouver -Dtests.file.encoding=UTF-8
[junit4] ERROR 0.00s | ContentStreamTest (suite) <<<
[junit4] > Throwable #1: java.lang.AssertionError: !!!! WARNING: best
effort to remove
C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800
FAILED !!!!!
[junit4] > at
__randomizedtesting.SeedInfo.seed([32A8B44CEE4187EC]:0)
[junit4] > at
org.apache.solr.SolrTestCaseJ4.afterClass(SolrTestCaseJ4.java:217)
[junit4] > at java.lang.Thread.run(Thread.java:744)
[junit4] Completed in 0.41s, 3 tests, 1 failure <<< FAILURES!
{noformat}
I would also change the message to no longer say "!!! WARNING !!!" -> we should
only print this with the annotation, otheriwse it should be a standard
assertion Error without "WARNING" included. The current message is a bit
confusing.
Otherwise: Thanks Mark, that was fast!
Dawid: I agree with you that we should fix the whole stuff globally on the
suite level. We should:
- remove the TEMP_DIR constant completely!
- forbid the File#deleteOnExit stuff
Uwe
> Almost all Solr tests no longer cleanup their temp dirs on Windows
> ------------------------------------------------------------------
>
> Key: SOLR-5914
> URL: https://issues.apache.org/jira/browse/SOLR-5914
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: 4.8
> Reporter: Uwe Schindler
> Assignee: Dawid Weiss
> Priority: Critical
> Fix For: 4.8
>
> Attachments: SOLR-5914 .patch, SOLR-5914 .patch,
> branch4x-jenkins.png, build-plugin.jpg, trunk-jenkins.png
>
>
> Recently the Windows Jenkins Build server has the problem of all-the time
> running out of disk space. This machine runs 2 workspaces (4.x and trunk) and
> has initially 8 Gigabytes of free SSD disk space.
> Because of the recently all-the time failing tests, the test framework does
> not forcefully clean up the "J0" working folders after running tests. This
> leads to the fact, that the workspace is filled with tons of Solr Home dirs.
> I tried this on my local machine:
> - run ant test
> - go to build/.../test/J0 and watch folders appearing: Almost every test no
> longer cleans up after shutting down, leaving a million of files there. This
> is approx 3 to 4 Gigabytes!!!
> In Lucene the folders are correctly removed. This has happened recently, so i
> think we have some code like ([~erickerickson] !!!):
> {{new Properties().load(new FileInputStream(...))}} that does not close the
> files. Because of this, the test's afterClass cannot clean up folders
> anymore. If you look in the test log, you see messages like "{{!!!! WARNING:
> best effort to remove
> C:\Users\JenkinsSlave\workspace\Lucene-Solr-4.x-Windows\solr\build\solr-core\test\J0\.\org.apache.solr.cloud.TestShortCircuitedRequests-1395693845226
> FAILED !!!!!}}" all the time.
> So if anybody committed some changes that might not close files correctly,
> please fix! Otherwise I have to disable testing on windows - and I will no
> longer run solr, tests, too: My local computer also uses gigabytes of temp
> space after running tests!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
