Github user shebiki commented on the pull request:
https://github.com/apache/lucene-solr/pull/40#issuecomment-38919593
Mikhail,
I understand your sentiment about having vision. When I started this pull
request I thought I had a nice clear direction in mind; to decouple Scorer from
Weight and thus allow Scorer classes to be more reusable. After taking some
time to think about your concerns I'm coming round to realize that there is
nothing to fix here. I nearly pushed for changing the weight reference to a
scorer to help the decoupling but realize that it'd still be helpful if someone
wants to stick a breakpoint in the code to diagnose a hairy issue.
Can I point this pull request back to it's first commit (db57c80) and see
if the coord cleanup is something that'd be helpful?
--Terry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
