[
https://issues.apache.org/jira/browse/SOLR-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954824#comment-13954824
]
Mark Miller commented on SOLR-5859:
-----------------------------------
Yes, very nice change. This approach is great.
Patch looks good, but some nits with the current version listed below:
bq. OCP
We info log closing OCP - we probably should not abbreviate it though, a user
won't know what it is.
bq. } else if( QUIT.equals(operation)){
{code}
}
String getId(){
return myId;
}
{code}
There are also some project formatting violations - eg spacing, missing new
line:
{code}
log.info("IsClosed :{} , {}", isClosed, this);
log.warn("OverseerCollectionProcessor.processMessage : "+ operation + " ,
"+ message.toString());
{code}
I think both of those are wrong - should be one log line under debug.
bq. import org.apache.zookeeper.data.Stat;
Unused import added.
> Harden the Overseer restart mechanism
> -------------------------------------
>
> Key: SOLR-5859
> URL: https://issues.apache.org/jira/browse/SOLR-5859
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Noble Paul
> Attachments: SOLR-5859.patch, SOLR-5859.patch
>
>
> SOLR-5476 depends on Overseer restart.The current strategy is to remove the
> zk node for leader election and wait for STATUS_UPDATE_DELAY +100 ms and
> start the new overseer.
> Though overseer ops are short running, it is not a 100% foolproof strategy
> because if an operation takes longer than the wait period there can be race
> condition.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
