[ https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955281#comment-13955281 ]
Yonik Seeley commented on SOLR-5488: ------------------------------------ bq. If there are no objections, I'll commit this early next week to trunk, and if nothing pops out in a few days merge it into 4x. Remember, this was only committed to trunk not because of test failures (which we didn't know about when it was committed to trunk), but to give time to solidify the API (which is much harder to change once it's "released"). After a quick look, there's probably more to do here. The biggest thing that popped out at me was the structure of the response - NamedList in some places that should probably be SimpleOrderedMap. Add "wt=json&indent=true" to some sample requests and it's much easier to see. > Fix up test failures for Analytics Component > -------------------------------------------- > > Key: SOLR-5488 > URL: https://issues.apache.org/jira/browse/SOLR-5488 > Project: Solr > Issue Type: Bug > Affects Versions: 4.7, 5.0 > Reporter: Erick Erickson > Assignee: Erick Erickson > Attachments: SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch, > SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch, > SOLR-5488.patch, SOLR-5488.patch, eoe.errors > > > The analytics component has a few test failures, perhaps > environment-dependent. This is just to collect the test fixes in one place > for convenience when we merge back into 4.x -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org