[ 
https://issues.apache.org/jira/browse/LUCENE-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956099#comment-13956099
 ] 

ASF subversion and git services commented on LUCENE-5559:
---------------------------------------------------------

Commit 1583530 from [~rcmuir] in branch 'dev/trunk'
[ https://svn.apache.org/r1583530 ]

LUCENE-5559: Add missing checks to TokenFilters with numeric arguments

> Argument validation for TokenFilters having numeric constructor parameter(s)
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-5559
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5559
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>    Affects Versions: 4.7
>            Reporter: Ahmet Arslan
>            Priority: Minor
>             Fix For: 4.8
>
>         Attachments: LUCENE-5559.patch, LUCENE-5559.patch, LUCENE-5559.patch, 
> LUCENE-5559.patch
>
>
> Some TokenFilters have numeric arguments in their constructors. They should 
> throw {{IllegalArgumentException}} for negative or meaningless values. 
> Here is some examples that demonstrates invalid/meaningless arguments :
> {code:xml}
>  <filter class="solr.LimitTokenCountFilterFactory" maxTokenCount="-10" />
> {code}
> {code:xml}
>  <filter class="solr.LengthFilterFactory" min="-5" max="-1" />
> {code}
> {code:xml}
>  <filter class="solr.LimitTokenPositionFilterFactory" maxTokenPosition="-3" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to