[ 
https://issues.apache.org/jira/browse/LUCENE-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935748#action_12935748
 ] 

Trejkaz commented on LUCENE-2348:
---------------------------------

I don't really want to argue good or bad design, because the fact is that it 
worked, and then Lucene core broke the functionality, and now you are claiming 
that some kinds of filter shouldn't be done as a filter anymore (what should 
they be done as, then?  I've already said that the other suggestions won't work 
in any fashion.)

But fine.

This wasn't the only filter in our system affected by this issue.  As long as 
LUCENE-2506 is put through, though, the rest of our filters which are _not_ 
"bad design" will still be able to work in the future without hacks on our end 
to make them work.
 

> DuplicateFilter incorrectly handles multiple calls to getDocIdSet for segment 
> readers
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2348
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2348
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>    Affects Versions: 2.9.2
>            Reporter: Trejkaz
>         Attachments: LUCENE-2348.patch, LUCENE-2348.patch
>
>
> DuplicateFilter currently works by building a single doc ID set, without 
> taking into account that getDocIdSet() will be called once per segment and 
> only with each segment's local reader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to