[ 
https://issues.apache.org/jira/browse/LUCENE-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962131#comment-13962131
 ] 

Uwe Schindler commented on LUCENE-5578:
---------------------------------------

Shouldn't maxPointer be initialized with getFileLength() if the version is 
below VERSION_CHECKSUM? Currently it is initialized with -1, which looks wrong. 
*This would never affect us, because we never merge accross versions, but we 
should maybe add a comment about this.*

> Stored fields might accumulate checksums on merges
> --------------------------------------------------
>
>                 Key: LUCENE-5578
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5578
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Blocker
>             Fix For: 4.8
>
>         Attachments: LUCENE-5578.patch, LUCENE-5578.patch
>
>
> The bulk merge operation of our stored fields format is optimized in order to 
> avoid decompressing data when not needed. In order to know the offset of the 
> end of the current block, it either consults the stored fields index, or uses 
> {{fieldsStream.length()}} for the last chunk.
> However, we just added checksums at the end of index files, so it might 
> currently copy the current checksum in addition to the last chunk, and then 
> write a new checksum.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to