[
https://issues.apache.org/jira/browse/LUCENE-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12936007#action_12936007
]
Michael McCandless commented on LUCENE-2777:
--------------------------------------------
Looks good Simon!
> Revise PagedBytes#fillUsingLengthPrefix* methods names
> ------------------------------------------------------
>
> Key: LUCENE-2777
> URL: https://issues.apache.org/jira/browse/LUCENE-2777
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: CSF branch, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Attachments: LUCENE-2777.patch
>
>
> PagedBytes has 3 different variants of fillUsingLengthPrefix. We need better
> names for that since CSFBranch already added a 4th one.
> here are some suggestions:
> {code}
> /** Reads length as 1 or 2 byte vInt prefix, starting @ start */
> public BytesRef fillLengthAndOffset(BytesRef b, long start)
> // was: public BytesRef fillUsingLengthPrefix(BytesRef b, long start)
> /** @lucene.internal Reads length as 1 or 2 byte vInt prefix, starting @
> start. Returns the block number of the term. */
> public int getBlockAndFill(BytesRef b, long start)
> // was: public BytesRef fillUsingLengthPrefix2(BytesRef b, long start)
> /** @lucene.internal Reads length as 1 or 2 byte vInt prefix, starting @
> start.
> * Returns the start offset of the next part, suitable as start parameter
> on next call
> * to sequentially read all BytesRefs. */
> public long getNextOffsetAndFill(BytesRef b, long start)
> // was: public BytesRef fillUsingLengthPrefix3(BytesRef b, long start)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
