I removed the fix version, because it is not fixed in that version. If we want to include this and respin, please reopen issue.
----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: [email protected] > -----Original Message----- > From: Uwe Schindler (JIRA) [mailto:[email protected]] > Sent: Wednesday, April 09, 2014 7:52 PM > To: [email protected] > Subject: [jira] [Updated] (LUCENE-5570) FSDirectory's fsync() is lenient > > > [ https://issues.apache.org/jira/browse/LUCENE- > 5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Uwe Schindler updated LUCENE-5570: > ---------------------------------- > > Fix Version/s: (was: 4.7.2) > > > FSDirectory's fsync() is lenient > > -------------------------------- > > > > Key: LUCENE-5570 > > URL: https://issues.apache.org/jira/browse/LUCENE-5570 > > Project: Lucene - Core > > Issue Type: Bug > > Components: core/store > > Reporter: Robert Muir > > Fix For: 4.8, 5.0 > > > > Attachments: LUCENE-5570.patch, LUCENE-5570.patch, > > LUCENE-5570_java6.patch, LUCENE-5570_zerobyte.patch > > > > > > This method has a lot of problems: > > 1. it tracks 'stale files' as it writes (this seems pointless), and > > only actually fsyncs the intersection of that 'stale files' and the > > filenames > passed as argument to sync(). So any bogus names passed to sync() are just > silently ignored 2. if "something bad happens" (e.g. two indexwriters/dirs on > the same path, or some other shenanigans), and the file is actually in stale > files, but was say actually deleted on the filesystem, the underlying fsync() > call will create a new 0-byte file and fsync that. > > In my opinion we should do none of this. we should throw exceptions > when this stuff is wrong. > > > > -- > This message was sent by Atlassian JIRA > (v6.2#6252) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] For additional > commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
