[
https://issues.apache.org/jira/browse/LUCENE-5588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965208#comment-13965208
]
Uwe Schindler commented on LUCENE-5588:
---------------------------------------
Cool, thanks. Nice blog post! In fact our current patch should be fine then?
Should we commit it to trunk and branch_4x? I will also check MacOSX on my VM
to validate if it also works on OSX, so i can modify the assert to check that
the sync succeeds on OSX. Currently it only asserts on Linux that no errors
occurred.
According to the blog post, windows does not work at all, so we are fine with
the "optimization" (early exit).
> We should also fsync the directory when committing
> --------------------------------------------------
>
> Key: LUCENE-5588
> URL: https://issues.apache.org/jira/browse/LUCENE-5588
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Reporter: Uwe Schindler
> Fix For: 4.8, 5.0
>
> Attachments: LUCENE-5588.patch, LUCENE-5588.patch
>
>
> Since we are on Java 7 now and we already fixed FSDir.sync to use FileChannel
> (LUCENE-5570), we can also fsync the directory (at least try to do it).
> Unlike RandomAccessFile, which must be a regular file, FileChannel.open() can
> also open a directory:
> http://stackoverflow.com/questions/7694307/using-filechannel-to-fsync-a-directory-with-nio-2
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
