[ https://issues.apache.org/jira/browse/SOLR-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967276#comment-13967276 ]
Hoss Man commented on SOLR-5963: -------------------------------- Hold up here folks ... completely replacing all uses of NamedList with SImpleOrderedMap in the analytics response is definitely _not_ the correct choice -- looking at the docs, there are clearly situations where the order matters. (notably when dealing with facets) Off the top of my head based on experimenting (and comparing what's on trunk with what's in Erick's patch here in this issue)... * each of the "fieldFacets" children (the per-field structure) needs to be an named list so that "olap.<request>.fieldfacet.<field>.sortstatistic" option will still be useful * each of the ""rangeFacets" children (the per-field structure) needs to be a named list so that range buckets will be n the correct order ... there may be other cases where using a NamedList is important -- those are just the ones that jumped out at me immediately. > Finalize interface and backport analytics component to 4x > --------------------------------------------------------- > > Key: SOLR-5963 > URL: https://issues.apache.org/jira/browse/SOLR-5963 > Project: Solr > Issue Type: Improvement > Affects Versions: 4.9, 5.0 > Reporter: Erick Erickson > Assignee: Erick Erickson > Attachments: SOLR-5963.patch > > > Now that we seem to have fixed up the test failures for trunk for the > analytics component, we need to solidify the API and back-port it to 4x. For > history, see SOLR-5302 and SOLR-5488. > As far as I know, these are the merges that need to occur to do this (plus > any that this JIRA brings up) > svn merge -c 1543651 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545009 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545053 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545054 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545080 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545143 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545417 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545514 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1545650 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1546074 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1546263 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1559770 https://svn.apache.org/repos/asf/lucene/dev/trunk > svn merge -c 1583636 https://svn.apache.org/repos/asf/lucene/dev/trunk > The only remaining thing I think needs to be done is to solidify the > interface, see comments from [~yo...@apache.org] on the two JIRAs mentioned, > although SOLR-5488 is the most relevant one. > [~sbower], [~houstonputman] and [~yo...@apache.org] might be particularly > interested here. > I really want to put this to bed, so if we can get agreement on this soon I > can make it march. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org