[ https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968996#comment-13968996 ]
Hoss Man commented on SOLR-445: ------------------------------- Tomas: * we need better class level javadocs for the TolerantUpdateProcessorFactory - basically everything currently in the TolerantUpdateProcessor's javadocs, plus some example configuration, plus a note about how "maxErrors" can be specified as a request param or as an init param and an explanation of the default behavior if "maxErrors" specified at all * would you mind renaming "tolerant-chain1" and "tolerant-chain2" with more descriptive names to make the tests easier to read? perhaps "tolerate-10-failures-chain" and "tolerate-unlimited-failures-chain" ? * even if "maxErrors" isn't reached, we should consider carefully whether or not it makes sense to be returning a "200" status code even if _every_ update command that's executed for a request fails. (ie: if maxErrors defaults to Integer.MAX_VALUE, and i send 100 docs and all 100 fail, should i really get a 200 status code back?) > Update Handlers abort with bad documents > ---------------------------------------- > > Key: SOLR-445 > URL: https://issues.apache.org/jira/browse/SOLR-445 > Project: Solr > Issue Type: Improvement > Components: update > Affects Versions: 1.3 > Reporter: Will Johnson > Fix For: 4.8 > > Attachments: SOLR-445-3_x.patch, SOLR-445-alternative.patch, > SOLR-445-alternative.patch, SOLR-445.patch, SOLR-445.patch, SOLR-445.patch, > SOLR-445.patch, SOLR-445_3x.patch, solr-445.xml > > > Has anyone run into the problem of handling bad documents / failures mid > batch. Ie: > <add> > <doc> > <field name="id">1</field> > </doc> > <doc> > <field name="id">2</field> > <field name="myDateField">I_AM_A_BAD_DATE</field> > </doc> > <doc> > <field name="id">3</field> > </doc> > </add> > Right now solr adds the first doc and then aborts. It would seem like it > should either fail the entire batch or log a message/return a code and then > continue on to add doc 3. Option 1 would seem to be much harder to > accomplish and possibly require more memory while Option 2 would require more > information to come back from the API. I'm about to dig into this but I > thought I'd ask to see if anyone had any suggestions, thoughts or comments. > -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org