[ 
https://issues.apache.org/jira/browse/LUCENE-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-5067:
--------------------------------

    Attachment: LUCENE-5067.patch

This is the tests work Mike did factored out of LUCENE-5561, and merged up to 
current trunk

I think we should commit this part and not let it get hung up on that 
particular directory?

> add a BaseDirectoryTestCase
> ---------------------------
>
>                 Key: LUCENE-5067
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5067
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Robert Muir
>         Attachments: LUCENE-5067.patch
>
>
> Currently most directory code is tested indirectly. But there are still 
> corner cases like LUCENE-5066, NRCachingDirectory.testNoDir, 
> TestRAMDirectory.testSeekToEOFThenBack, that only target specific directories 
> where some user reported the bug. If one of our other directories has these 
> bugs, the best we can hope for is some other lucene test will trip it 
> indirectly and we will find it after lots of debugging...
> Instead we should herd up all these tests into a base class and test every 
> directory explicitly and directly with it (like we do with the codec API).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to