[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973130#comment-13973130
]
Noble Paul edited comment on SOLR-5473 at 4/17/14 4:41 PM:
-----------------------------------------------------------
bq. At a minimum, these methods should be well doc'd or marked internal/expert
Actually we need to mark those methods as internal/expert. I don't see a more
appropriate method name for those
bq.ClusterStater#getCachedCollection and ClusterStater#getCachedReplica
ClusterStater#getCachedCollection can be made private.
ClusterStater#getCachedReplica can be renamed to
ClusterStater#getReplica(String collectionName, String coreNodeName, boolean
cachedOnly)
I can't think of a better name for getCommonCollection() , we can mark it as
'internal' only
bq.It's visible right here in some logging: Registering watch for external
collection {}
I missed the logging part, That'll b fixed
And credits, of course
was (Author: noble.paul):
bq. At a minimum, these methods should be well doc'd or marked internal/expert
Actually we need to mark those methods as internal/expert. I don't see a more
appropriate method name for those
bq.ClusterStater#getCachedCollection and ClusterStater#getCachedReplica
ClusterStater#getCachedCollection can be made private.
ClusterStater#getCachedReplica can be renamed to
ClusterStater#getReplica(String collectionName, String coreNodeName, boolean
cachedOnly)
I can't think of a better name for getCommonCollection() , we can mark it as
'internal' only
bq.It's visible right here in some logging: Registering watch for external
collection {}
I missed the logging part, That'll b fixed
> Make one state.json per collection
> ----------------------------------
>
> Key: SOLR-5473
> URL: https://issues.apache.org/jira/browse/SOLR-5473
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Noble Paul
> Assignee: Noble Paul
> Fix For: 5.0
>
> Attachments: SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, ec2-23-20-119-52_solr.log, ec2-50-16-38-73_solr.log
>
>
> As defined in the parent issue, store the states of each collection under
> /collections/collectionname/state.json node
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
