[
https://issues.apache.org/jira/browse/SOLR-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973573#comment-13973573
]
Hoss Man edited comment on SOLR-5776 at 4/17/14 11:51 PM:
----------------------------------------------------------
[[email protected]]...
1) I don't think you need to override {{nextBytes}} with a No-Op method .. as
long as you override generateSeed we should be fine
2) there's a potential AIOOB error with your implementation of {{generateSeed}}
-- the contract says that the byte[] returned will have whatever length was
specified in the argument, so this could break spectacularly in a future
version of jetty/java
3) I'm not sure that you need {{NullSecureRandom}} at all -- if you go back to
Steve's patch, and just ensure that you call {{setSeed(new byte[]
\{'f','u'\})}} on the result of {{SecureRandom.getInstance("SHA1PRNG")}} beore
letting jetty have it, then generateSeed should never, ever be called.
*EDIT:* mid-air-collision, deleted things miller addressed in his previous
comment
was (Author: hossman):
[[email protected]]...
1) I don't think you need to override {{nextBytes}} with a No-Op method .. as
long as you override generateSeed we should be fine
2) there's a potential AIOOB error with your implementation of {{generateSeed}}
-- the contract says that the byte[] returned will have whatever length was
specified in the argument, so this could break spectacularly in a future
version of jetty/java
3) I'm not sure that you need {{NullSecureRandom}} at all -- if you go back to
Steve's patch, and just ensure that you call {{setSeed(new byte[]
\{'f','u'\})}} on the result of {{SecureRandom.getInstance("SHA1PRNG")}} beore
letting jetty have it, then generateSeed should never, ever be called.
4) if we are going to use {{NullSecureRandom}} then we probably shouldn't also
add the SecureRandomAlgorithm option since it isn't used?
4) I'm fairly certain this portion of your commit was not intentional:
https://svn.apache.org/viewvc/lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java?r1=1588388&r2=1588387&pathrev=1588388
> Look at speeding up using SSL with tests.
> -----------------------------------------
>
> Key: SOLR-5776
> URL: https://issues.apache.org/jira/browse/SOLR-5776
> Project: Solr
> Issue Type: Test
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-5776.patch, SOLR-5776.patch
>
>
> We have to disable SSL on a bunch of tests now because it appears to sometime
> be ridiculously slow - especially in slow envs (I never see timeouts on my
> machine).
> I was talking to Robert about this, and he mentioned that there might be some
> settings we could change to speed it up.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
