[ 
https://issues.apache.org/jira/browse/LUCENE-5617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974160#comment-13974160
 ] 

Michael McCandless commented on LUCENE-5617:
--------------------------------------------

+1 to cutover to real check not assert, and IndexInput.length() not 
Directory.fileLength.  I think we should remove Directory.fileLength.

> don't rely on directory metadata for stored fields 'maxpointer', change to 
> hard check
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5617
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5617
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.8
>
>         Attachments: LUCENE-5617.patch
>
>
> in the case of the new format:
>   its not good to use Dir.fileLength in the assert
>   assert should be a hard check
> in the case of the old format:
>   its really not good to use Dir.fileLength in the computation



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to