[ 
https://issues.apache.org/jira/browse/SOLR-6006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-6006:
-----------------------------

    Attachment: SOLR-6006.patch

Patch, retrieves Solrj test deps to {{solr/solrj/test-lib/}}.  Solr-core 
{{ivy.xml}} needed to changes too, since the solr-core classpath includes 
{{solr/solrj/lib/}}.  Tests pass under Ant and, after {{ant get-maven-poms}}, 
under Maven.

The only compile-phase logging dependency Solrj retains is slf4j-api - turns 
out Solrj doesn't need the log4j dependency, even for tests.

I'll see if it's useful to make the same change in the Solr contribs other than 
dataimporthandler, which already has the {{test-lib/}} setup.

> SolrJ maven pom file specifying log4j as a dependency
> -----------------------------------------------------
>
>                 Key: SOLR-6006
>                 URL: https://issues.apache.org/jira/browse/SOLR-6006
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.7.2
>            Reporter: Steven Scott
>            Priority: Minor
>         Attachments: SOLR-6006.patch
>
>
> I'm not sure what version this first appeared in, as we just bumped from 4.5 
> to 4.7, but log4j is specified as a dependency in the solr-solrj pom.xml, and 
> without the optional flag. I checked out the source to verify that there 
> isn't actually a dependency on log4j (doesn't seem to be), but I wasn't able 
> to decipher the ant build (looks like there's a pom.xml.template that 
> generates the pom with dependencies coming from Ivy?)
> Anyway, this is an issue since now we have to manually <exclude> log4j from 
> every project that depends on SolrJ.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to