[
https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979520#comment-13979520
]
Michael McCandless commented on LUCENE-5628:
--------------------------------------------
bq. Can we reduce the number of lines of code in the new method? It's not even
comparable to the current code.
I'll see if I can simplify it somehow ...
bq. How much of the loc is the cycle detection?
This is really a miniscule part of it: just look for whoever touches
the pathStates.
bq. How much of the loc is code optimization?
It's not optimization; in fact I imagine this impl is slower.
bq. Can the old code please be added to automatontestutil as slowxxx and
compared against the new one with random automata?
Great idea, I did that.
> SpecialOperations.getFiniteStrings should not recurse
> -----------------------------------------------------
>
> Key: LUCENE-5628
> URL: https://issues.apache.org/jira/browse/LUCENE-5628
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5628.patch, LUCENE-5628.patch
>
>
> Today it consumes one Java stack frame per transition, which when used by
> AnalyzingSuggester is per character in each token. This can lead to stack
> overflows if you have a long suggestion.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
