Aaron LaBella created SOLR-6013:
-----------------------------------
Summary: Fix method visibility of Evaluator, refactor
DateFormatEvaluator for extensibility
Key: SOLR-6013
URL: https://issues.apache.org/jira/browse/SOLR-6013
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Affects Versions: 4.7
Reporter: Aaron LaBella
Fix For: 4.8
Attachments:
0001-change-method-variable-visibility-and-refactor-for-extensibility.patch
This is similar to issue 5981, the Evaluator class is declared as abstract, yet
the parseParams method is package private? Surely this is an oversight, as I
wouldn't expect everyone writing their own evaluators to have to deal with
parsing the parameters.
Similarly, I needed to refactor DateFormatEvaluator because I need to do some
custom date math/parsing and it wasn't written in a way that I can extend it.
Please review/apply my attached patch to the next version of Solr, ie: 4.8 or
4.9 if I must wait.
Thanks!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
