[
https://issues.apache.org/jira/browse/LUCENE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988060#comment-13988060
]
Michael McCandless commented on LUCENE-5634:
--------------------------------------------
bq. Or are you comparing the speedup by this patch in combination with the
precision step change?
Baseline was the patch w/ precStep=8 and comp was the patch w/ precStep=4. I
just re-ran to be sure; this is IndexGeoNames.java in luceneutil if you want to
try ... it's easy to run, you just need to download/unzip geonames corpus
first. Net/net precStep=4 is very costly and doesn't seem to buy much query
time speedups from my tests on LUCENE-5609.
> Reuse TokenStream instances in Field
> ------------------------------------
>
> Key: LUCENE-5634
> URL: https://issues.apache.org/jira/browse/LUCENE-5634
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5634.patch, LUCENE-5634.patch, LUCENE-5634.patch,
> LUCENE-5634.patch
>
>
> If you don't reuse your Doc/Field instances (which is very expert: I
> suspect few apps do) then there's a lot of garbage created to index each
> StringField because we make a new StringTokenStream or
> NumericTokenStream (and their Attributes).
> We should be able to re-use these instances via a static
> ThreadLocal...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
