[
https://issues.apache.org/jira/browse/LUCENE-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989454#comment-13989454
]
Robert Muir commented on LUCENE-5640:
-------------------------------------
I ran the benchmark 10 times for trunk and patch (indexing with reuse disabled,
time in milliseconds, StandardAnalyzer)
Trunk
mean: 24386.1
median: 24377.0
stddev: 189.4
Patch
mean: 25047.6
median: 25076.5
stddev: 151.8
I tried with JapaneseAnalyzer, thinking the patch would be faster in this case
(has a lot of non-standard attributes). But its actually slower
Trunk
mean: 45059.3
median: 45065
stddev: 629.5
Patch:
mean: 51382.7
median: 51496
stddev: 196.3
So something is up I think.
> Cleanup Token class
> -------------------
>
> Key: LUCENE-5640
> URL: https://issues.apache.org/jira/browse/LUCENE-5640
> Project: Lucene - Core
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Uwe Schindler
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5640.patch, LUCENE-5640.patch, LUCENE-5640.patch,
> LUCENE-5640.patch, LUCENE-5640.patch
>
>
> We should remove code duplication in the Token class:
> - copy constructors
> - reinit() shit
> - non-default clone()
> This is too bugy. Most of the methods can be simply removed. In fact, Token
> should just look like a clone of all AttributeImpl it implements.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
