[
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998594#comment-13998594
]
Christine Poerschke commented on SOLR-6067:
-------------------------------------------
Okay, i think the problem is the last buildAndRunCollectorChain call:
In the github https://github.com/apache/lucene-solr/pull/48 diff
{noformat}
DocSetCollector setCollector = new DocSetDelegateCollector(maxDoc>>6, maxDoc,
topCollector);
buildAndRunCollectorChain(qr, query, luceneFilter, setCollector, cmd,
pf.postFilter);
{noformat}
was simplification for
{noformat}
DocSetCollector setCollector = new DocSetDelegateCollector(maxDoc>>6, maxDoc,
topCollector);
Collector collector = setCollector;
buildAndRunCollectorChain(qr, query, luceneFilter, collector, cmd,
pf.postFilter);
{noformat}
and in the patch we see
{noformat}
DocSetCollector setCollector = new DocSetCollector(maxDoc>>6, maxDoc);
Collector collector = MultiCollector.wrap(topCollector, setCollector);
buildAndRunCollectorChain(qr, query, luceneFilter, setCollector, cmd,
pf.postFilter);
{noformat}
i.e. the collector assignment's result is completely ignored. I'll rebase and
re-push to github without use of the simplification and then hopefully patch
creation will be unproblematic.
> add buildAndRunCollectorChain method to reduce code duplication in
> SolrIndexSearcher
> ------------------------------------------------------------------------------------
>
> Key: SOLR-6067
> URL: https://issues.apache.org/jira/browse/SOLR-6067
> Project: Solr
> Issue Type: Improvement
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-6067.patch
>
>
> https://github.com/apache/lucene-solr/pull/48 has the proposed change.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
