[ 
https://issues.apache.org/jira/browse/LUCENE-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-5684:
---------------------------------------

    Attachment: LUCENE-5684.patch

Patch, I think it's ready.  I also tried to clean up 
StandardDirectoryReader.open a bit: it was scary how it would assign to 
newReaders[i] a non-incRef'd reader.  I was sure it was a bug, and made a test 
case to show it, but the test case wouldn't fail and on staring at the code 
some more I noticed the i++ in the finally clause that prevents the bug ...

> Add best effort detection when index is removed & recreated before 
> openIfChanged
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-5684
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5684
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-5684.patch
>
>
> I dug into the confusing NPE from the java-user email with subject "[lucene 
> 4.6] NPE when calling IndexReader#openIfChanged".
> It happens because the app was opening an IndexReader, then rm -rf the entire 
> index, build a new one, then calling reopen.  This is invalid usage (the app 
> should instead use IW.deleteAll, or open new IW with OpenMode.CREATE), but 
> I'd like to add a minor best effort check...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to