[ 
https://issues.apache.org/jira/browse/LUCENE-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004300#comment-14004300
 ] 

Robert Muir commented on LUCENE-4236:
-------------------------------------

I tried to clean this up as much as I can...

OR tasks look fine (with BS1 disabled on both checkouts):

{noformat}
                    Task   QPS trunk      StdDev   QPS patch      StdDev        
        Pct diff
            OrNotHighLow      958.58      (2.1%)      988.37      (2.7%)    
3.1% (  -1% -    8%)
              OrHighHigh       18.76      (8.2%)       19.83     (15.1%)    
5.7% ( -16% -   31%)
               OrHighMed       43.12      (8.3%)       45.64     (15.3%)    
5.9% ( -16% -   32%)
               OrHighLow       44.76      (9.1%)       47.92     (16.9%)    
7.1% ( -17% -   36%)
            OrNotHighMed      168.34      (3.4%)      189.12      (4.3%)   
12.3% (   4% -   20%)
           OrNotHighHigh       45.16      (3.5%)       60.43     (12.2%)   
33.8% (  17% -   51%)
           OrHighNotHigh       27.07      (3.4%)       36.27     (12.6%)   
34.0% (  17% -   51%)
            OrHighNotMed       79.81      (3.7%)      111.10     (15.3%)   
39.2% (  19% -   60%)
            OrHighNotLow       96.78      (4.0%)      137.49     (17.1%)   
42.1% (  20% -   65%)
{noformat}

It would also be nice to run the "eg.filter.tasks" but these are currently 
broken in luceneutil.


> clean up booleanquery conjunction optimizations a bit
> -----------------------------------------------------
>
>                 Key: LUCENE-4236
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4236
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-4236.patch, LUCENE-4236.patch, LUCENE-4236.patch, 
> LUCENE-4236.patch, LUCENE-4236.patch
>
>
> After LUCENE-3505, I want to do a slight cleanup:
> * compute the term conjunctions optimization in scorer(), so its applied even 
> if we have optional and prohibited clauses that dont exist in the segment 
> (e.g. return null)
> * use the term conjunctions optimization when optional.size() == 
> minShouldMatch, as that means they are all mandatory, too.
> * don't return booleanscorer1 when optional.size() == minShouldMatch, because 
> it means we have required clauses and in general BS2 should do a much better 
> job (e.g. use advance).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to