[
https://issues.apache.org/jira/browse/LUCENE-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006759#comment-14006759
]
Shai Erera commented on LUCENE-5683:
------------------------------------
You replaced a hash lookup by an instanceof check ... is that really better? I
wonder if that change is really worth it .. i.e. how slow can a hash lookup be
compared to an instanceof check. Anyway, your call.
> Improve SegmentReader.getXXXDocValues
> -------------------------------------
>
> Key: LUCENE-5683
> URL: https://issues.apache.org/jira/browse/LUCENE-5683
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Robert Muir
> Attachments: LUCENE-5683.patch
>
>
> Today we do two hash lookups, where in most cases a single one is enough.
> E.g. SR.getNumericDocValues initializes the FieldInfo (first lookup in
> FieldInfos), however if that field was already initialized, we can simply
> check dvFields.get(). This can be improved in all getXXXDocValues as well as
> getDocsWithField.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
