[ 
https://issues.apache.org/jira/browse/LUCENE-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008394#comment-14008394
 ] 

Shai Erera commented on LUCENE-5706:
------------------------------------

I checked the patch on SOLR-5944 and I only see this line related to 
updateNumericDocValue:

{code}
writer.updateNumericDocValue(updateTerm, field.name(), 
field.numericValue().longValue());
{code}

So it already assumes the update value isn't null right?

> Don't allow unsetting values through DocValues updates
> ------------------------------------------------------
>
>                 Key: LUCENE-5706
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5706
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>
> Spinoff from LUCENE-5680: we shouldn't allow unsetting values through 
> DocValues updates, at least not until there's a real usecase for it. This 
> will simplify a lot of the internal code, as well make the numeric update API 
> work w/ primitive {{long}} instead of {{Long}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to