[
https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009988#comment-14009988
]
Shai Erera commented on LUCENE-5708:
------------------------------------
bq. Hmm which tests rely on using the same IWC?
Hmm ... I don't remember. All I remember is that while I worked on preventing
sharing IWC between writers (LUCENE-4876), there were a bunch of tests that
reused the IWC. I fixed them by simply cloning it, but I admit I didn't check
if initializing a new IWC each time serves their purpose. I just assume that if
so many tests did that, there ought to be a reason beyond just convenience, but
I could be wrong.
What I'm worried is that by not cloning Jenkins will trip (which is good!), or
worse - that those tests will stop asserting what they asserted before. So I
just wanted to point that out. If we're ready to take the risk, I'm fine with
it, because eventually we're discussing tests here .. there's nothing
functionally missing from an app's perspective.
> Remove IndexWriterConfig.clone
> ------------------------------
>
> Key: LUCENE-5708
> URL: https://issues.apache.org/jira/browse/LUCENE-5708
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5708.patch, LUCENE-5708.patch
>
>
> We originally added this clone to allow a single IWC to be re-used against
> more than one IndexWriter, but I think this is a mis-feature: it adds
> complexity to hairy classes (merge policy/scheduler, DW thread pool, etc.), I
> think it's buggy today.
> I think we should just disallow sharing: you must make a new IWC for a new
> IndexWriter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
