[
https://issues.apache.org/jira/browse/SOLR-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated SOLR-6119:
------------------------------
Attachment: SOLR-6119.patch
Varun, your patch is fine but it doesn't address the original problem. I've
added a try/finally block around rm because the backup folder cannot be removed
(it's still open on Windows). I attach an updated patch that removes this block
-- if you run it now, you should be seeing the same issue (you may need a
Windows machine for this, though).
{code}
[08:00:08.376] ERROR 3.78s | TestReplicationHandler.doTestBackup <<<
> Throwable #1: java.io.IOException: Could not remove the following files
(in the order of attempts):
>
C:\Work\lucene-solr-svn\trunk\solr\build\solr-core\test\J0\.\temp\solr.handler.TestReplicationHandler-B751491BC59B33CA-001\solr-instance-001\collection1\data\snapshot.eyxtuk
>
> at
__randomizedtesting.SeedInfo.seed([B751491BC59B33CA:F6DA697EE225C085]:0)
> at org.apache.lucene.util.TestUtil.rm(TestUtil.java:118)
> at
org.apache.solr.handler.TestReplicationHandler.doTestBackup(TestReplicationHandler.java:1559)
...
{code}
> TestReplicationHandler attempts to remove open folders
> ------------------------------------------------------
>
> Key: SOLR-6119
> URL: https://issues.apache.org/jira/browse/SOLR-6119
> Project: Solr
> Issue Type: Bug
> Reporter: Dawid Weiss
> Priority: Minor
> Attachments: SOLR-6119.patch, SOLR-6119.patch, SOLR-6119.patch
>
>
> TestReplicationHandler has a weird logic around the 'snapDir' variable. It
> attempts to remove snapshot folders, even though they're not closed yet. My
> recent patch uncovered the bug but I don't know how to fix it cleanly -- the
> test itself seems to be very fragile (for example I don't understand the
> 'namedBackup' variable which is always set to true, yet there are
> conditionals around it).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
