[
https://issues.apache.org/jira/browse/SOLR-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017385#comment-14017385
]
Spyros Kapnissis commented on SOLR-6131:
----------------------------------------
Hi Ahmet, Yes, I already attached a patch that does that (replaces deprecated
Token class with newer TokenStream API's AttributeSource).
> Remove deprecated Token class from solr.spelling package
> --------------------------------------------------------
>
> Key: SOLR-6131
> URL: https://issues.apache.org/jira/browse/SOLR-6131
> Project: Solr
> Issue Type: Improvement
> Components: spellchecker
> Affects Versions: 4.8.1
> Reporter: Spyros Kapnissis
> Priority: Minor
> Labels: spellchecker
> Attachments: SOLR-6131.patch
>
>
> The deprecated Token class is used everywhere in the spelling package. I am
> attaching a patch that refactors/replaces all occurrences with the
> AttributeSource class. The tests are passing.
> Note: the AttributeSource class also replaces Token as a hash key in many
> places. Having stricter equals/hashCode requirements than Token, I am a bit
> concerned that it could produce some duplicate suggestions, especially in the
> case of ConjunctionSolrSpellChecker where merging of the different spell
> checking suggestions takes place. If this initial approach is fine, I can
> create some extra checks/unit tests for this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
