[
https://issues.apache.org/jira/browse/LUCENE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966167#action_12966167
]
Michael McCandless commented on LUCENE-2790:
--------------------------------------------
Patch looks great!
My only concern is... it looks like addIndexes(IR[]), with compound file used
in the end, may fail to delete the non-compound files once the SegmentInfo is
committed? Maybe we should add a test to show the failure...
I think we need to do something like this:
{noformat}
// delete new non cfs files directly: they were never
// registered with IFD
deleter.deleteNewFiles(merger.getMergedFiles(merge.info));
{noformat}
> IndexWriter should call MP.useCompoundFile and not LogMP.getUseCompoundFile
> ---------------------------------------------------------------------------
>
> Key: LUCENE-2790
> URL: https://issues.apache.org/jira/browse/LUCENE-2790
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2790.patch, LUCENE-2790.patch, LUCENE-2790.patch,
> LUCENE-2790.patch
>
>
> Spin off from here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/112311.
> I will attach a patch shortly that addresses the issue on trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
