Yonik, I'm in the process of backporting, and this commit and the subsequent revert on QueryParsingTest looks weird, so I thought I would double check the intent. See below
Begin forwarded message: > From: [email protected] > Date: September 25, 2010 5:06:11 PM EDT > To: [email protected] > Subject: svn commit: r1001318 - in /lucene/dev/trunk/solr: CHANGES.txt > src/java/org/apache/solr/search/FunctionQParser.java > src/test/org/apache/solr/search/QueryParsingTest.java > src/test/org/apache/solr/search/function/TestFunctionQuery.java > Reply-To: [email protected] > ============================================================================== > --- > lucene/dev/trunk/solr/src/test/org/apache/solr/search/QueryParsingTest.java > (original) > +++ > lucene/dev/trunk/solr/src/test/org/apache/solr/search/QueryParsingTest.java > Sat Sep 25 21:06:10 2010 > @@ -133,13 +133,7 @@ public class QueryParsingTest extends So > flds = sort.getSort(); > assertEquals(flds[0].getType(), SortField.FLOAT); > assertEquals(flds[0].getField(), "weight"); > - > - try { > - //bad number of parens, but the function parser can handle an extra > close > - sort = QueryParsing.parseSort("pow(weight,2)) desc, bday asc", schema); > - } catch (SolrException e) { > - assertTrue(false); > - } > +gvim > //Test literals in functions > sort = QueryParsing.parseSort("strdist(foo_s, \"junk\", jw) desc", > schema); > flds = sort.getSort(); Namely, it looks like like we had a test that checked for dealing with extra parens. Then, perhaps you made some typo that inserted the chars: gvim in place of that test. Subsequently in rev 1001320 you kind of reverted the commit by removing the gvim, but did you intend to restore the test or are you seeing it as a bad test? -Grant
