[
https://issues.apache.org/jira/browse/SOLR-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026308#comment-14026308
]
Christine Poerschke commented on SOLR-6087:
-------------------------------------------
https://github.com/apache/lucene-solr/pull/57 is rebaselining against trunk
which now contains SOLR-6067 refactor changes.
An alternative change would be to have a 'finally' block which calls the
'finish()' method.
However on the basis that exceptions other than TimeExceededException and
EarlyTerminatingCollectorException may well have been caused or thrown by one
of the collectors in the collector chain i think it's best to call finish only
for known, expected code paths i.e. don't potentially call finish on a
collector that is already in trouble. Also the 'finish()' method itself could
throw.
> SolrIndexSearcher makes no DelegatingCollector.finish() call when
> IndexSearcher throws an expected exception.
> -------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6087
> URL: https://issues.apache.org/jira/browse/SOLR-6087
> Project: Solr
> Issue Type: Bug
> Reporter: Christine Poerschke
> Priority: Minor
>
> This seems like an omission. github pull request with proposed change to
> follow.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
