[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-2894:
---------------------------
Attachment: SOLR-2894.patch
Started getting back into this yesterday (i should have several large blocks of
time for this issue this week & next week)...
bq. Me and Brett discovered serveral bugs with our mincount and the changes I
made to our refinement requests that resulted in the odd behavior you were
seeing.
Awesome! ... glad to see the test was useful.
bq. Not everything is super happy. I get what look like solrcloud errors when
running certain seeds
Hmmm... that is a weird error. People sometimes see errors in solr tests that
use threads related to timing and/or assertions of things that haven't happened
yet - but i don't remember ever seeing anything like this type of problem with
initialization of the cores.
do these failures reproduce for you with the same seeds? can you post the full
reproduce line that you get with these failures?
bq. I forgot this patch also comments out the randomUsableUnicodeString to just
be a simple string, BUT I've changed it back on my box and It seems to be fine.
yep -- it also still had one of my nocommits so that it was _only_ pivoting on
string fields, but even w/o that it's worked great for me on many iterations.
----
Revised patch - mostly cleaning up the lingering issues in TestCloudPivotFacet
but a few other minor fixes of stuff i noticed.
Detailed changes compared to previous patch...
* removed "TestDistributedSearch.java.orig" that seems to have been included in
patch by mistake
* cleanup TestCloudPivotFacet
** fixed randomUsableUnicodeString()
** fix nocommit about testing pivot on non-string fields
** fixed the depth checking (we can assert the *max* depth, but that's it)
** removed weird (unused) "int ss = 2" that got added to assertNumFound
*** was also in some dead code in PivotFacetProcessor?
** refactored cut/pate methods from Cursor test into baseclass
* I removed the NullGoesLastComparator class and replaced it with a
compareWithNullLast helper method in PivotFacetField (and added a unit test for
it)
** the Comparator contract is pretty explicit about null, and this class
violated that
** it was only being used for simple method calls, not passed to anything that
explicitly needed a Comparator, so there wasn't a strong need for a standalone
class
----
My "next step" plans...
* review DistributedFacetPivotTest in depth more - add more strong assertions
** at first glance, it looks like a lot of the test is following the example of
most existing distrib tests of relying on comparisons between the controlClient
and the distrib client -- in my opinion that's a bad pattern, and i'd like to
add some explicit assertions on the results of all the {{this.query(...)}} calls
* re-review the new pivot code (and the changes to facet code) in general
** it's been a while since my last skim, and i know you've tweaked a bunch
based on my previous comments
** i'll take a stab at adding more javadocs to some of the new methods as i
make sense of them
** where possible, i'm going to try to add unit tests for some of the new low
level methods you've introduced -- largely as a way to help ensure i understand
what they do
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2894-mincount-minification.patch,
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894_cloud_test.patch,
> dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
