[
https://issues.apache.org/jira/browse/SOLR-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029090#comment-14029090
]
ASF subversion and git services commented on SOLR-6048:
-------------------------------------------------------
Commit 1602138 from [~noble.paul] in branch 'dev/trunk'
[ https://svn.apache.org/r1602138 ]
SOLR-6048 the assert was not really failing the test
> Fix asserts for SolrDocument, SolrInputDocument and SolrInputField in
> SolrTestCaseJ4
> ------------------------------------------------------------------------------------
>
> Key: SOLR-6048
> URL: https://issues.apache.org/jira/browse/SOLR-6048
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-6048.patch, SOLR-6048.patch, SOLR-6048.patch
>
>
> SOLR-5265 added these asserts to check equality of SolrDocument,
> SolrInputDocument and SolrInputField instead of adding a compare method to
> any of these classes.
> But these are actually compare methods. So we should rename them to
> compareSolrDocument() etc. and in TestJavaBinCodec fix the usage. Currently
> in TestJavaBinCodec the backcompat test is broken.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
