[ 
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029319#comment-14029319
 ] 

Andrew Muldowney edited comment on SOLR-2894 at 6/12/14 4:34 PM:
-----------------------------------------------------------------

I'm on it. 
I'm loving all these added asserts. I've added a few asserts that test the 
exact data that proves refinement worked,  I'll work through the whole 
changeset and post up what I've got.

I want to bring up a separate issue that we've been dealing with in this patch.

SolrJ and its response types. I'm fairly certain that field facets always 
return the value of any field as a string, so "true" instead of boolean.true 
and dates in the external format not the pretty printed format. This isn't 
wholly true in pivot facets right now and it causes some wierdness in the code. 
I'd personally like to just use the string data types like field facet does, 
and remove the hacky functionality that sends back objects for solrJ
Hoss, thoughts?


was (Author: andrew.muldowney):
I'm on it.

> Implement distributed pivot faceting
> ------------------------------------
>
>                 Key: SOLR-2894
>                 URL: https://issues.apache.org/jira/browse/SOLR-2894
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erik Hatcher
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-2894-mincount-minification.patch, 
> SOLR-2894-reworked.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894_cloud_test.patch, dateToObject.patch, pivot_mincount_problem.sh
>
>
> Following up on SOLR-792, pivot faceting currently only supports 
> undistributed mode.  Distributed pivot faceting needs to be implemented.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to