[ 
https://issues.apache.org/jira/browse/LUCENE-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030559#comment-14030559
 ] 

Robert Muir commented on LUCENE-5757:
-------------------------------------

No lots of stuff is using RamUsageEstimator helper methods and constants, its 
just that one of them is a crawler.

Currently we banned the crawler method with forbidden-apis for speed and 
infinite-crawl reasons, but instead i'd rather use it as a test method, and 
e.g. maybe add callback or filter parameter to it to limit what it crawls (just 
gear the whole api at testing).

This way we can test all these rambytesused methods in lucene, which today are 
completely untested.

> Move RAMUsageEstimator "reflector" to test-framework
> ----------------------------------------------------
>
>                 Key: LUCENE-5757
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5757
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> This method is "banned" already because it can crawl slowly across large 
> object graphs. 
> I think it should be in the test framework. It needs enhancements for testing 
> such as some way to filter what is crawled.
> Currently lots of code in lucene tries to provide accounting information but 
> its all totally untested. We need to fix the test situation or remove 
> Accountable and such methods completely.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to