[ 
https://issues.apache.org/jira/browse/LUCENE-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032382#comment-14032382
 ] 

Robert Muir commented on LUCENE-5765:
-------------------------------------

nice, i hadnt thought of filtering by field (versus say by class).

we may want to change to that or at least provide it separately, because you 
get more type safety (in this case just return false if its 
SlowCompositeReader.class or whatever), but lets start with this patch!

> Add tests to OrdinalMap.ramBytesUsed
> ------------------------------------
>
>                 Key: LUCENE-5765
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5765
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-5765.patch
>
>
> I noticed it doesn't take into account the shallow size of the {{ordDeltas}} 
> array (I would not expect it to be a big deal, but still it's better to have 
> it tested).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to