That doesn’t make sense to me either, Toke. Have you tried changing it and running tests to see that they pass?
~ David Smiley Freelance Apache Lucene/Solr Search Consultant/Developer http://www.linkedin.com/in/davidwsmiley On Mon, Jun 16, 2014 at 8:39 AM, Toke Eskildsen <[email protected]> wrote: > I am having a bit of a challenge getting > https://issues.apache.org/jira/browse/SOLR-5894 > to work with SolrCloud. I have traced it down to the distributed > faceting request always having mincount=0 when limit > 0, regardless of > what I specify mincount to. > > In the method modifyRequest in FacetComponent.java at > > https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java > line 238 is > > dff.initialMincount = 0; // TODO: we could change this to 1, > but would then need more refinement for small facet result sets? > > I do not understand the logic here: When my request is for mincount > 0, > when does it ever make sense to have terms with count=0 returned from > any shard? > > - Toke Eskildsen, State and University Library, Denmark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
