[
https://issues.apache.org/jira/browse/SOLR-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042657#comment-14042657
]
Alan Woodward commented on SOLR-6195:
-------------------------------------
>From the point of view of the code I think this still belongs in
>UpdateHandlerInfo - maybe add a bit of logic to SolrConfig to check both
>places when building the UpdateHandlerInfo object?
As far as tests go, this is kind of tricky to test properly. You'd want to
trigger a merge and then close and see if things shut down before the merge
goes through. I'll have a think.
> replace updateHandler/indexWriter/closeWaitsForMerges with
> indexConfig/closeWriterWaitsForMerges
> ------------------------------------------------------------------------------------------------
>
> Key: SOLR-6195
> URL: https://issues.apache.org/jira/browse/SOLR-6195
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
>
> SOLR-6125 added a new "closeWaitsForMerges" config option, but in my opinion
> this was done too hastily w/o enough consideration to how/shere the option is
> configured.
> * it's currently "updateHandler/indexWriter/closeWaitsForMerges"
> ** there has never been an "updateHandler/indexWriter" section in
> solrconfig.xml until now
> ** this is the only setting that currently exists in this section
> * this setting, although used by DirectUpdateHandler2, does not (from a user
> perspective really fit with the other existing settings in {{<updateHandler>}}
> ** i think from a user perspective, it would make much more sense in
> {{<indexConfig>}} along side the other merge related settings.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
