[
https://issues.apache.org/jira/browse/SOLR-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitaliy Zhovtyuk updated SOLR-5095:
-----------------------------------
Attachment: SOLR-5095.patch
1. Made map key as JMX canonical name that correspond to registered mbean and
unique
2. Overriden Map.get in order to translate existing key to JMX canonical name
3. Changed unregister method: removed unused InfoMBean parameter, changed
unregister to work on canonical name
4. JMX names reminded unchanged and backward compatible
> SolrCore.infoRegistry needs overhauled with some form of "namespacing"
> ----------------------------------------------------------------------
>
> Key: SOLR-5095
> URL: https://issues.apache.org/jira/browse/SOLR-5095
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Attachments: SOLR-5095.patch, SOLR-5095_bug_demo.patch
>
>
> While investigating SOLR-3616 / SOLR-2715, I realized the failure i was
> seeing didn't seem to be related to the initial report of that bug, and
> instead seemed to be due to an obvious and fundemental limitation in the way
> SolrCore keeps track of "plugins" using the infoRegistry: It's just a
> {{Map<String, SolrInfoMBean>}} keyed off of the name of the plugin, but there
> is not "namespacing" used in the infoRegistry, so two completley different
> types of plugins with the same name will overwrite each other.
> When looking at data using something like /admin/mbeans, this manifests
> itself solely as missing objects: last one .put() into the infoRegistry
> "wins" -- using JMX, both objects are actually visible because of how JMX
> ObjectNames are built arround a set of key=val pairs, and a bug in how
> JmxMonitorMap unregisters existing MBeans when .put() is called on a key it
> already knows about (the unregister call is made using an ObjectName built
> using the infoBean passed to the put() call -- if infoBean.getName() is not
> exactly the same as the previous infoBean put() with the same key, then the
> MbeanServer will continue to know about both of them)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
