[ 
https://issues.apache.org/jira/browse/SOLR-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathias H. updated SOLR-6214:
-----------------------------

    Description: 
The numberToKeep param for snapshots doesn't work anymore. If you set the param 
to '2', only '1' backup is kept.

In the ReplicationHandler in line 377 snapShooter.validateCreateSnapshot(); 
creates an empty directory for the new snapshot. The deleteOldBackups() method 
in Snapshooter which will be executed before the backup is created, now sees 
the two directories an deletes the old one. But this is wrong because the empty 
directory for the new backup should not be considered.

  was:
The numberToKeep param for snapshots doesn't work anymore. If you set the param 
to '2', only '1' backup is kept.

In the ReplicationHandler in line 377 snapShooter.validateCreateSnapshot(); 
creates an empty directory for the new snapshot. The deleteOldBackups() method 
in Snapshooter which will be executed before the backup will be created, now 
sees the two directories an deletes the old one. But this is wrong because the 
empty directory for the new backup should not be considered.


> Snapshots numberToKeep param only keeps n-1 backups
> ---------------------------------------------------
>
>                 Key: SOLR-6214
>                 URL: https://issues.apache.org/jira/browse/SOLR-6214
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.9
>            Reporter: Mathias H.
>            Priority: Minor
>
> The numberToKeep param for snapshots doesn't work anymore. If you set the 
> param to '2', only '1' backup is kept.
> In the ReplicationHandler in line 377 snapShooter.validateCreateSnapshot(); 
> creates an empty directory for the new snapshot. The deleteOldBackups() 
> method in Snapshooter which will be executed before the backup is created, 
> now sees the two directories an deletes the old one. But this is wrong 
> because the empty directory for the new backup should not be considered.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to