[ 
https://issues.apache.org/jira/browse/SOLR-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-6211:
-----------------------------

    Attachment: SOLR-6211-branch_4x.patch
                SOLR-6211-trunk.patch

branch_4x patch adds overridden {{TrieDateField.hasProperty()}} method, as 
mentioned in my previous comment.  Also adds overridden 
{{TrieDateField.isMultiValued()}} method, which suffered the same problem (not 
forwarding calls to the wrapped implementation).

Both patches add all Trie fields to 
{{PrimitiveFieldTypeTest.testDefaultOmitNorms()}}.

Committing shortly.

> TrieDateField doesn't default to omitNorms=true
> -----------------------------------------------
>
>                 Key: SOLR-6211
>                 URL: https://issues.apache.org/jira/browse/SOLR-6211
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.9
>            Reporter: Michael Ryan
>         Attachments: SOLR-6211-branch_4x.patch, SOLR-6211-trunk.patch
>
>
> In SOLR-3140, omitNorms=true was made the default for all primitive fields. 
> But this is not the case for TrieDateField - if the fieldType config for a 
> TrieDateField has no omitNorms set, the fields will have norms.
> It definitely looks like it was intended for TrieDateField to default to 
> omitNorms=true, because in the example schema.xml, omitNorms=true was removed 
> from tdate.
> I think TrieDateField.init() just needs to call super.init() to fix this. 
> Right now it is initializing its wrapped field, but not itself.
> There were some changes around this in trunk in SOLR-5936, but I haven't 
> tested to see if it's fixed there. It might have covered this bug up even 
> further, as there is now a test in PrimitiveFieldTypeTest for this, but it 
> uses the overridden TrieDateField.hasProperty() method, which is not the way 
> that SchemaField actually accesses the field type properties.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to